Remove unnecessary generic type parameters for delaySubscription methods in Single#5511
Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom Jul 21, 2017
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #5511 +/- ##
===========================================
+ Coverage 96.1% 96.11% +0.01%
- Complexity 5807 5808 +1
===========================================
Files 631 631
Lines 41285 41285
Branches 5732 5732
===========================================
+ Hits 39676 39681 +5
+ Misses 638 629 -9
- Partials 971 975 +4
Continue to review full report at Codecov.
|
Member
|
Thanks. The JLS seems to consider such change as binary compatible. /cc @JakeWharton |
JakeWharton
approved these changes
Jul 21, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was running into an issue with using the
delaySubscription(long time, TimeUnit unit)while testing aSingleand I saw that theUgeneric type parameter was there unnecessarily. I believe this is only a Kotlin specific issue as I tried playing around in Java and there was no inference error upon compilation. To get it to compile for Kotlin, I would need to specify the generic type parameter and it didn't matter what I set it to asAnywas a valid option:.delaySubscription<Any>(5, TimeUnit.SECONDS). I also went throughFlowable,Observable, andMaybeand saw that the generics were missing for the time-specificdelaySubscriptionmethods so I believe they should be removed fromSingleas well to help keep things consistent and remove this compilation error for future Kotlin users.